Ignore overrides for variable_name
#1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #1169 `variable_name should not apply to overriding properties`.
Generated by 🚫 danger |
|
@marcelofabri @jpsim Any idea what happened to Danger on this build? 99% faster with this little change makes no sense to me. Also some of the violations "fixed" in other rules that are not the |
Current coverage is 82.18% (diff: 100%)@@ master #1199 diff @@
==========================================
Files 165 165
Lines 8179 8182 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6721 6724 +3
Misses 1458 1458
Partials 0 0
|
|
@aamctustwo I have no idea, but I triggered it again and it seems we're good now! |
marcelofabri
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1169
variable_name should not apply to overriding properties.Summary
Updated
variable_nameto ignore overrides.